Analysis: read a rarely-read meter as coarse, not absent; newest rows first
ci / build-test (push) Successful in 2m41s
ci / build-test (push) Successful in 2m41s
Three things a reported Heizoel page got wrong at once. Its tank is dipped a few times a year and its burner read every few months, which is exactly the shape the coverage rules had not been walked through. "No data" for data that exists. A tank books nothing until the next dipstick closes the interval, so the stretch after the last dipstick is covered by no run at all, and a bucket no run covers was reported missing. The burner, whose run reaches into the window, said "only coarser data" -- the honest answer -- so one card claimed there was nothing while the coverage panel beside it listed years of data. A bucket that no run covers, no gap overlaps and no opening balance explains now reports the meter's resolution when its preceding coverage is within one interval of its own class: it is not silent, it is read rarely. A meter that does book its own buckets and stops -- a dead hourly source, a sheet asked about a later month -- still reads missing. Auto answering twelve months with one bar. Coarse only means "longer than a month", so a dipstick taken each autumn straddles a New Year as surely as a month start: coarsening the chart to years bought nothing and cost every point. The planning resolution now caps coarse at month when a run crosses a local year edge, and a series that cannot resolve the natural size no longer coarsens the whole chart -- it is drawn at that size with its buckets marked, which the chart and table already explain. A page contradicting itself. The comparison line above the ranking was fed the leading measure's matched coverage but worded as if it spoke for the page, directly above a burner row that did compare. It now names the figure it is about. Alongside: the "largest changes" ranking no longer drops a meter whose change is not comparable. It ranks what can be ranked, then lists the rest with their values and the reason -- the tank had been vanishing from its own energy type. And every dated table now reads newest first, as lists are read; charts stay chronological left to right, and the CSV export stays ascending for spreadsheets. A-41 to A-43 in the note record the three rules.
This commit is contained in:
@@ -302,28 +302,17 @@ internal sealed class AnalysisRun
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// The coarsest resolution among the data covering the period (D-05): auto never plans finer. A run divided at
|
||||
/// month boundaries resolves months whatever its class.
|
||||
/// The coarsest resolution among the data covering the period (D-05): auto never plans finer. What each run asks
|
||||
/// for is <see cref="ResolutionClassifier.PlanningResolution"/> — a run divided at month boundaries resolves
|
||||
/// months whatever its class (A-03), and a run coarser than a month only pushes the chart to years when years
|
||||
/// can place it (A-41).
|
||||
/// </summary>
|
||||
private ResolutionClass? CoarsestNeeded()
|
||||
{
|
||||
ResolutionClass? coarsest = null;
|
||||
foreach (var id in _dataLeaves)
|
||||
{
|
||||
foreach (var run in _leaves[id].CappedRuns(Now))
|
||||
{
|
||||
if (run.IsGap || run.From >= _period.To || run.To <= _period.From)
|
||||
{
|
||||
continue;
|
||||
}
|
||||
|
||||
var resolution = run.DividedAtMonths && run.Resolution > ResolutionClass.Month ? ResolutionClass.Month : run.Resolution;
|
||||
coarsest = coarsest is { } c && c >= resolution ? c : resolution;
|
||||
}
|
||||
}
|
||||
|
||||
return coarsest;
|
||||
}
|
||||
private ResolutionClass? CoarsestNeeded() =>
|
||||
ResolutionClassifier.PlanningResolution(
|
||||
_dataLeaves
|
||||
.SelectMany(id => _leaves[id].CappedRuns(Now))
|
||||
.Where(run => !run.IsGap && run.From < _period.To && run.To > _period.From),
|
||||
_zone);
|
||||
|
||||
// ---------------------------------------------------------------- comparison and matched coverage
|
||||
|
||||
|
||||
Reference in New Issue
Block a user